Repository navigation
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…addAdmin-page # Conflicts: # src/ONYXKEYS.ts # src/pages/domain/Admins/DomainAdminsPage.tsx
# Conflicts: # src/pages/domain/Admins/DomainAdminsPage.tsx
# Conflicts: # src/ROUTES.ts # src/SCREENS.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/libs/Navigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts # src/libs/Navigation/types.ts
# Conflicts: # src/ROUTES.ts # src/SCREENS.ts # src/languages/en.ts # src/libs/API/types.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/libs/Navigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts # src/libs/Navigation/types.ts # src/libs/actions/Domain.ts # src/pages/domain/Admins/DomainAdminsPage.tsx # src/selectors/Domain.ts # src/types/onyx/DomainErrors.ts # src/types/onyx/DomainPendingActions.ts # src/types/onyx/index.ts
|
|
||
| const filteredPersonalDetails = availableOptions.personalDetails | ||
| .filter((option) => option.accountID !== currentlySelectedUser?.accountID) | ||
| .filter((option) => option.accountID && !adminIDs?.includes(option.accountID)); |
There was a problem hiding this comment.
const filteredPersonalDetails = availableOptions.personalDetails.filter(
({ accountID }) =>
accountID &&
accountID !== currentlySelectedUser?.accountID &&
!adminIDs?.includes(accountID)
|
Should we support a multiple-choice? 2025-12-19.13.58.50.mov |
|
And we can't deselect an already selected user 2025-12-19.14.05.36.mov |
|
@ZhenjaHorbach header updated!
nope, we shouldn't. Command accepts only one email
Should we be able to do that? We can just leave the screen. If we want to choose another user we can click on them |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: The diff is too large to include in this comment (97KB), so I've created a gist for you: 📋 View the translation diff here 📋 Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
you're right, we should |
# Conflicts: # src/languages/de.ts # src/languages/en.ts # src/languages/es.ts # src/languages/fr.ts # src/languages/it.ts # src/languages/ja.ts # src/languages/nl.ts # src/languages/pl.ts # src/languages/pt-BR.ts # src/languages/zh-hans.ts # src/libs/API/types.ts # src/libs/actions/Domain.ts # src/pages/domain/Admins/DomainAdminsPage.tsx # src/selectors/Domain.ts
|
@situchan I think all comments should be addressed now |
| function DomainAdminsSettingsPage({route}: DomainAdminsSettingsPageProps) { | ||
| const {domainAccountID} = route.params; | ||
|
|
||
| const styles = useThemeStyles(); |
There was a problem hiding this comment.
| const styles = useThemeStyles(); |
|
Screenshot is missing. Are we blocked on |
| text={translate('domain.admins.addAdmin')} | ||
| icon={icons.Plus} | ||
| innerStyles={[shouldUseNarrowLayout && styles.alignItemsCenter]} | ||
| style={[shouldUseNarrowLayout && styles.flexGrow1, shouldUseNarrowLayout && styles.mb3]} |
There was a problem hiding this comment.
style={shouldUseNarrowLayout && [styles.mb3, styles.flexGrow1]}
I can't reliably access @mountiny ngrok, not sure why Screen.Recording.2025-12-22.at.18.05.37.mov |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb Chromemchrome.moviOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
Nice! I clicked many times on Invite button but API is called only once Screen.Recording.2025-12-23.at.12.08.48.AM.mov |
I suppose we already should have this If we don't have this label, then it's worth fixing again |
|
"No results found" shows when anything typed in search. |
@situchan @ZhenjaHorbach I don't think we do that in other places in the app. I verified that on |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.2.87-0 🚀
|
|
This PR failing because of a regression issue |
|
This should have been "No QA". Backend is not deployed yet. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.87-7 🚀
|




Explanation of Change
This PR adds an “Add Admin” screen to the RHP. The screen is accessible from domain/admins after clicking the “Add Admin” button.
Fixed Issues
$ #77743
PROPOSAL:
Tests
Go to the domain and open the Admins tab.
Open RHP → Add Admins.
Add an admin by selecting a user from the list and clicking Invite.
Expected result:
A new admin should be added to the Admins list.
Offline tests
Go to the domain and open the Admins tab.
Open RHP → Add Admins.
Select a user from the list and click Invite.
Expected result:
The new admin is added optimistically to the Admins list as a greyed-out entry.
QA Steps
Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari